php阿里云oss-sdk上传失败情况处理

现象

oss上传没有成功，但是拿到了地址，导致访问时返回404状态码

思路

我们先看自己写的上传oss部分代码

public function oss(string $file, string $object)
{
    $ossClient = new OssClient($this->config['accessKeyId'], $this->config['accessKeySecret'], $this->config['endpoint']);
    $result    = $ossClient->uploadFile($this->config['bucket'], ltrim($object, '/'), $file);
    return $result['oss-request-url'];
}

按理说是由sdk返回的result中拿到的地址，上传失败应该会直接抛出异常
再看其中uploadFile代码部分

public function uploadFile($bucket, $object, $file, $options = NULL)
{
    // ...省略代码
    $response = $this->auth($options);
    $result = new PutSetDeleteResult($response);
    return $result->getData();
}

其中主要方法是$this->auth($options)，再进去看

private function auth($options)
{
    // ...省略代码

    try {
        $request->send_request();
    } catch (RequestCore_Exception $e) {
        throw(new OssException('RequestCoreException: ' . $e->getMessage()));
    }
    $response_header = $request->get_response_header();
    $response_header['oss-request-url'] = $requestUrl;
    $response_header['oss-redirects'] = $this->redirects;
    $response_header['oss-stringtosign'] = $string_to_sign;
    $response_header['oss-requestheaders'] = $request->request_headers;

    $data = new ResponseCore($response_header, $request->get_response_body(), $request->get_response_code());
    //retry if OSS Internal Error
    if ((integer)$request->get_response_code() === 500) {
        if ($this->redirects <= $this->maxRetries) {
            //Sets the sleep time betwen each retry.
            $delay = (integer)(pow(4, $this->redirects) * 100000);
            usleep($delay);
            $this->redirects++;
            $data = $this->auth($options);
        }
    }
    
    $this->redirects = 0;
    return $data;
}

可以看到抛异常情况只在send_request方法，而里面只在curl本身无法请求（比如host无法解析）才会抛出RequestCore_Exception异常
也就是说如果是业务类的错误是会正常走下去的
虽然response_code为500时会有重试，但是在这之前已经创建了response对象
如果非500错误，或者超过重试次数都会返回这个对象，最终情况就是不管怎么样都会返回result结构体

解决

在拿到result结构体后先进行response_code判断，代码如下

public function oss(string $file, string $object)
{
    $ossClient = new OssClient($this->config['accessKeyId'], $this->config['accessKeySecret'], $this->config['endpoint']);
    $result    = $ossClient->uploadFile($this->config['bucket'], ltrim($object, '/'), $file);
    if ($result['info']['http_code'] !== 200) {
        throw new OssException('上传失败');
    }
    return $result['oss-request-url'];
}

补充

查阅了官方示例也没有对这些情况进行处理，示例如下：
地址：https://help.aliyun.com/document_detail/88473.html

// ...省略代码
try{
    $ossClient = new OssClient($accessKeyId, $accessKeySecret, $endpoint);

    $ossClient->uploadFile($bucket, $object, $filePath);
} catch(OssException $e) {
    printf(__FUNCTION__ . ": FAILED\n");
    printf($e->getMessage() . "\n");
    return;
}
print(__FUNCTION__ . "OK" . "\n");

附上文档中其他错误码说明，文档链接：https://help.aliyun.com/document_detail/31978.html#section-orz-dlw-bz